Skip to content

Commit

Permalink
Merge branch 'maksym-ic-admin-set-btc-config' into 'master'
Browse files Browse the repository at this point in the history
fix: add ProposeToSetBitcoinConfig to ic-admin

This MR fixes running `ic-admin` with secret key or HSM.

Without this change running the following command would fail.
```shell
$ bazel run //rs/registry/admin:ic-admin -- \
        --use-hsm \
        --key-id 01 \
        --slot 0 \
        --pin "$dfx_hsm_pin" \
        --nns-url "https://ic0.app" \
        propose-to-set-bitcoin-config \
        ...

INFO: Build completed successfully, 2 total actions
thread 'main' panicked at 'Specifying a secret key or HSM is only supported for methods that interact with NNS handlers.', rs/registry/admin/src/main.rs:4349:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
``` 

See merge request dfinity-lab/public/ic!13215
  • Loading branch information
maksymar committed Jun 27, 2023
2 parents f528e38 + 2654e1d commit 64fbab2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions rs/registry/admin/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4339,6 +4339,7 @@ async fn main() {
SubCommand::ProposeToAddHostOsVersion(_) => (),
SubCommand::ProposeToManageHostOsVersion(_) => (),
SubCommand::ProposeToCreateServiceNervousSystem(_) => (),
SubCommand::ProposeToSetBitcoinConfig(_) => (),
_ => panic!(
"Specifying a secret key or HSM is only supported for \
methods that interact with NNS handlers."
Expand Down

0 comments on commit 64fbab2

Please sign in to comment.