Merge branch 'eichhorl/dealing-relay' into 'master'

feat(ecdsa): FOLLOW-618 Do not relay ECDSA dealings

ECDSA dealings are added to the validated pool if public verification succeeds. Private verification is done at a later point when generating support for the dealing. If the latter verification fails, the dealing is removed from the pool, potentially giving the dealer the chance of sending another invalid dealing. The possibility of receiving many invalid messages from a malicious node exists for all artifacts. However, for these signed ECDSA dealings the issue is exacerbated, since they may be advertised and relayed to other nodes before failure of private verification removes them from the validated pool. 

With this MR we stop relaying ECDSA dealings to avoid the aforementioned problem. 

See merge request dfinity-lab/public/ic!12742

rs/artifact_pool/src/ecdsa_pool.rs

@@ -410,7 +410,8 @@ impl MutablePool<EcdsaArtifact, EcdsaChangeSet> for EcdsaPoolImpl {
                 }
                 EcdsaChangeAction::MoveToValidated(message) => {
                     match &message {
-                        EcdsaMessage::EcdsaDealingSupport(_) => (),
+                        EcdsaMessage::EcdsaDealingSupport(_)
+                        | EcdsaMessage::EcdsaSignedDealing(_) => (),
                         _ => adverts.push(EcdsaArtifact::message_to_advert(&message)),
                     }
                     unvalidated_ops.remove(ecdsa_msg_id(&message));
@@ -886,9 +887,8 @@ mod tests {
                     ],
                 );
                 assert!(result.purged.is_empty());
-                // No advert is created for moved dealing support
-                assert_eq!(result.adverts.len(), 1);
-                assert_eq!(result.adverts[0].id, msg_id_2);
+                // No adverts are created for moved dealings and dealing support
+                assert!(result.adverts.is_empty());
                 assert_eq!(result.changed, ProcessingResult::StateChanged);
                 check_state(&ecdsa_pool, &[], &[msg_id_1, msg_id_2]);
             })