Skip to content

Commit

Permalink
Merge branch 'rumenov/dontrelaychttpshares' into 'master'
Browse files Browse the repository at this point in the history
chore: don't relay canister http shares

Relaying shares of the small feature results thousands artifacts generated for only few user http requests.

Disabling shares should not impact correctness or security of the feature. 

See merge request dfinity-lab/public/ic!15634
  • Loading branch information
rumenov committed Oct 28, 2023
2 parents 4ee333a + 2c152d1 commit dc09a9c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions rs/artifact_pool/src/canister_http_pool.rs
Expand Up @@ -129,7 +129,6 @@ impl MutablePool<CanisterHttpArtifact> for CanisterHttpPoolImpl {
}
CanisterHttpChangeAction::MoveToValidated(share) => {
if self.unvalidated.remove(&share).is_some() {
adverts.push(CanisterHttpArtifact::message_to_advert(&share));
self.validated.insert(share, ());
}
}
Expand Down Expand Up @@ -308,7 +307,6 @@ mod tests {

assert!(pool.contains(&id1));
assert!(!pool.contains(&id2));
assert_eq!(result.adverts[0].id, id1);
assert!(result.poll_immediately);
assert!(result.purged.is_empty());
assert_eq!(share1, pool.lookup_validated(&id1).unwrap());
Expand Down

0 comments on commit dc09a9c

Please sign in to comment.