Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash.mo need fixing and every prim module M needs an M.hash function, update guide to relect this. #134

Open
crusso opened this issue Jul 15, 2020 · 3 comments

Comments

@crusso
Copy link
Contributor

crusso commented Jul 15, 2020

No description provided.

@matthewhammer
Copy link
Contributor

@crusso What does "need[s] fixing" mean in the issue title? How would we know if it were fixed, for instance?

@matthewhammer
Copy link
Contributor

every prim module M needs an M.hash function

+1

@matthewhammer
Copy link
Contributor

matthewhammer commented Jul 23, 2020

Actually writing this function properly is important, but I've been hesitating, since:

  1. It's a lot of work to write this in Motoko for every type, even with the proper combinators
  2. Perhaps the language itself will absorb hashing for shared data? If so, then 1 becomes trivial in most cases.

OTOH, if it's important to do very soon, we can bite the bullet and write these for each module, by hand. But, I hesitate still, as I thought I saw somewhere else that we are discussing hashing for shared data though (item 2 above) in the nearer term?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants