Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Spaces/URL Encoding in Asset Canister http_request isn't supported #1569

Closed
hansl opened this issue Apr 5, 2021 · 1 comment
Closed

Bug: Spaces/URL Encoding in Asset Canister http_request isn't supported #1569

hansl opened this issue Apr 5, 2021 · 1 comment
Assignees
@ericswanson-dfinity

Comments

@hansl
Copy link
Contributor

hansl commented Apr 5, 2021

It seems like URLs like Hello%20World in http_request is searched in the HashMap as is, but uploading is done without the URL Encoding.

We need one of 2 things:

  • Either dfx encode URLs, or
  • (preferred) http_request decode URL before doing lookup in the HashMap.

IMO the second option is more in line with expected behaviour, where the HashMap keys are verbatim the filename, with HTTP requests encoded as expected but decoded before being searched.
@ericswanson-dfinity
Copy link
Member

Fixed by #1601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericswanson-dfinity ericswanson-dfinity

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hansl @ericswanson-dfinity