Export Excel fixes for issues #92, #52, #41, #33.

[W1M0R]

These changes fix issues #92, #52, #41, #33.

Export-Excel.Impl.ps1: Implementation details for the new Export-Excel contributions.
Export-Excel.Impl.Tests.ps1: Tests for the implementation details.
Export-Excel.ps1: Export-Excel is now a Cmdlet (supports -Verbose parameter). Added -DateTimeFormat and -ColumnOptions parameters. Extracted value and format code into New-CellData function.
Export-Excel.Tests.ps1: Updated module import.
Issues.Tests.ps1: Contains a test for every issue fixed.

[dfinke]

Wow!

I'd prefer not to have Impl in the file name. ExcelHelpers.ps1 might work.

Any chance you could add ps1 files in the Examples folder showing this off?
Then we could point to those in the README.md. Also, The standalone ps1 example files can be used in short gif videos.

Thanks again

[W1M0R]

No problem, as soon as I get a chance, I'll do that. I don't know how to make the gif videos. What app do you use?

[dfinke]

No rush. If you want to do the animations that'd be cool, was just mentioning it so I'd remember to do it.

I use gifcam

[W1M0R]

I have detected a few conversion issues when using my own excel datasets, so I'll continue to work on this functionality in my number_formats branch. My 'experimental' branch is a merge of everything I need in ImportExcel. I'll let you know when I feel more confident about the changes. But at least this gives you an opportunity to inspect the code and offer suggestions. Thanks dfinke!

[Cirzen]

Some very good stuff in here, great job Willie. Looking forward to seeing some of this merged.
Glad I could help with one of the tests!
David

[dfinke]

OK. I think I misread @W1M0R last comment. So this PR can be merged? And he is doing more checking on code in his branch?

[W1M0R]

Thanks @Cirzen

@dfinke It is not ready to merge yet. Some of my test cases are failing. Should I close it for now?

[dfinke]

Let's leave it open. No need to set it up again later.

[cpolydorou]

Hello,

Has this been merged?

[dfinke]

No. The person working it through didn't pick it break up. What were you looking for?

[Cirzen]

Hi doug, also chiming in here, the leading zero issue was my primary concern. Was that fixed in the main stream?

[dfinke]

Unfortunately no. This was a large change submitted and the person providing it had to move on to other things before we could vet all of it and merge. Get Outlook for Android<https://aka.ms/ghei36> On Tue, Jan 17, 2017 at 7:06 AM -0500, "David Johnson" <notifications@github.com<mailto:notifications@github.com>> wrote: Hi doug, also chiming in here, the leading zero issue was my primary concern. Was that fixed in the main stream? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#101 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAEGumMJmrMzzvOASLLub2vmagpNgpvEks5rTK67gaJpZM4IUL52>.

[cpolydorou]

Hi Doug,

My issue is that long numbers are imported with scientific format. (#92).

[DarkLite1]

This is actually already done with my previous pull request that is already accepted and merged. This one could be closed as duplicate and implemented.

[cpolydorou]

Hi DarkLite1,

Could you please describe in short how to import numbers without getting the scientific format?

Chris

[DarkLite1]

I think you misunderstood something. This pull request is about Export-Excel and you are looking for an extra feature in Import-Excel if I'm not mistaken?

@dfinke , we could use the same function used in Export-Excel, I think I called it Add-CellValue, in Import-Excel to accommodate the user's needs?

[cpolydorou]

Yes, you are correct. However, it would be very helpful if you could describe the way to export just in case.

[DarkLite1]

You can find the way to export the numbers when doing Get-Help Export-Excel -Examples.
@dfinke , this PR can be closed.

[dfinke]

-------------------------- EXAMPLE 3 --------------------------

$ExcelParams = @{

Path    = $env:TEMP + '\Excel.xlsx'
    Show    = $true
    Verbose = $true
}
Remove-Item -Path $ExcelParams.Path -Force -EA Ignore
[PSCustOmobject][Ordered]@{
    Date      = Get-Date
    Formula1  = '=SUM(F2:G2)'
    String1   = 'My String'
    String2   = 'a'
    IPAddress = '10.10.25.5'
    Number1   = '07670'
    Number2   = '0,26'
    Number3   = '1.555,83'
    Number4   = '1.2'
    Number5   = '-31'
    PhoneNr1  = '+32 44'
    PhoneNr2  = '+32 4 4444 444'
    PhoneNr3  =  '+3244444444'
} | Export-Excel @ExcelParams -NoNumberConversion IPAddress, Number1

Exports all data to the Excel file 'Excel.xslx' and tries to convert all values to numbers where possible except
for 'IPAddress' and 'Number1'. These are stored in the sheet 'as is', without being converted to a number.

[cpolydorou]

Thanks!

[DarkLite1]

@dfinke I think this can be closed now.