Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS suggestion: Statement of need #45

Closed
gautam-sharma1 opened this issue May 5, 2024 · 1 comment
Closed

JOSS suggestion: Statement of need #45

gautam-sharma1 opened this issue May 5, 2024 · 1 comment

Comments

@gautam-sharma1
Copy link

After reading the draft, I got a sense that movement_primitives does claim to be faster than other repos in the same space. If that's the case, then it will be good to add that to the "Statement of Need".

Also, is there any way I can reproduce the results?

@AlexanderFabisch
Copy link
Member

After reading the draft, I got a sense that movement_primitives does claim to be faster than other repos in the same space. If that's the case, then it will be good to add that to the "Statement of Need".

It is fast for Python, but dmpbbo in C++ is faster for most cases with few dimensions. In high-dimensional cases this library seems to be better than dmpbbo though. So I don't know if I can claim this as an advantage of this library over others. In the summary I mention that Cython is used to speed up online execution. What do you think?

Also, is there any way I can reproduce the results?

I just uploaded most of the benchmark code to this gist: https://gist.github.com/AlexanderFabisch/a69534fe425d305d7550eb526825cf2f

The C++ code for dmpbbo is currently missing though. I'll need some time to recover it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants