Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sortedLastIndex sortedLastIndexBy: implement without directly delegating to lodash #53

Closed
dflemstr opened this issue Aug 20, 2016 · 1 comment
Closed

sortedLastIndex sortedLastIndexBy: implement without directly delegating to lodash #53

dflemstr opened this issue Aug 20, 2016 · 1 comment
Labels
E-easy Feature L-js

Comments

@dflemstr
Copy link
Owner

For the sake of iteration speed, a lot of rq functionality was implemented by directly delegating to lodash. This is not optimal because the use of this.collect() and/or this.spread() means that intermediary arrays are allocated unnecessarily. The code of sortedLastIndex sortedLastIndexBy should be changed to abuse the streaming nature of rq processes while still passing the current doctests. For debugging, tee can be used to check the streaming behavior of the process.
@dflemstr
Copy link
Owner Author

Already pretty optimal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Feature L-js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dflemstr