Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests; make tests reproducable #22

Merged
merged 1 commit into from May 1, 2018
Merged

Conversation

RobertBorg
Copy link
Contributor

PR contains the following

  • Two bug fixes when using wasm-bindgen with nodejs option.
  • Switching the projects internal package manager to npm as running yarn in examples directories caused yarn to recursivley cache project -> examples -> project -> ... until it had eaten up my ~ 70GB free space
  • Bumped jest timeouts to 10 mins
  • Locked down versions of all dependencies

I might've missed something but hopefully we can have reliable ci moving forward

@dflemstr
Copy link
Owner

dflemstr commented May 1, 2018

It's unfortunate that we need to use npm instead of yarn but the benefits clearly outweigh! Thanks for doing these changes!

@dflemstr dflemstr merged commit 51a7d2a into dflemstr:master May 1, 2018
@RobertBorg
Copy link
Contributor Author

Agreed. I'll try to revisit the issue when i get time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants