Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme on setting the default toolchain #33

Merged
merged 1 commit into from Oct 7, 2018

Conversation

voneiden
Copy link
Contributor

@voneiden voneiden commented Oct 7, 2018

A small thing, but as somebody completely new to Rust, I had to dig quite deep to figure out why my build failed (especially since the latest release of rust-native-wasm-loader swallows the errors). I presume anyone who uses this loader wants to default to the nightly.

@dflemstr
Copy link
Owner

dflemstr commented Oct 7, 2018

It would be nice to add this, but I would recommend doing echo nightly > rust-toolchain in your repository instead. That way, you don't need to change global state (set global default toolchain version) for each separate project.

@voneiden
Copy link
Contributor Author

voneiden commented Oct 7, 2018

Right on, thanks for the tip, I've updated the PR according to that.

@dflemstr dflemstr merged commit f6b5562 into dflemstr:master Oct 7, 2018
@dflemstr
Copy link
Owner

dflemstr commented Oct 7, 2018

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants