Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dflib-jdbc: TableSaver to create target table if missing #11

Open
andrus opened this issue Mar 3, 2019 · 0 comments
Open

dflib-jdbc: TableSaver to create target table if missing #11

andrus opened this issue Mar 3, 2019 · 0 comments

Comments

@andrus
Copy link
Collaborator

andrus commented Mar 3, 2019

TableSaver should optionally create the target table if it is missing. There are a few challenges to solve here:

  • DDL for table creation is often DB-specific (particularly column types, such as dates, times, etc)
  • We don't have a robust API to determine the type of each column in the DataFrame. A "brute-force" implementation will require scanning every cell, and coming up with the JDBC type that would accumulate all values in a given column.
  • Determining proper length of VARCHAR / VARBINARY

As a quick workaround we need an API for the caller to provide desired column definitions in the target DB format. Long-term we'll need DB-specific JdbcConnector and better DF type introspection facilities.

@andrus andrus changed the title TableSaver to create target table if missing dflib-jdbc: TableSaver to create target table if missing Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant