New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare to send manuscript to collaborators and friends #61
Comments
@dfm I'm fine with cutting the kernel approximation section. This was more useful for my own benefit to see that the damped-sinusoids could represent a range of kernel behaviors. If we do want to simulate from a process, I would suggest the exponential-squared as this was the hardest kernel to approximate. The exponential-sine has already been addressed in the stellar periodicity section (both are effective models for rotational variability). |
@dfm On second thought, if someone wants to use a specific kernel to model data with celerite, it might make sense to include these approximations as options. I agree that it makes better sense to just use a combination of damped sinusoids from the start, but you never know what others may prefer... |
@dfm For instance, if someone had done an analysis with a particular kernel with another code (say george), and wanted to compare/validate the results using celerite, they may want to have access to the same kernel parameterized in the same manner as george. |
I'm going to have to disagree with you. Unless there's a physical motivation for using something like an exponential squared then the real thing that you want to validate is that your inferences don't depend on the code/kernel that you choose! I don't want to encourage people to use something like these approximations without doing more tests and having a justified motivation. If you end up with different results then it would be hard to ensure that it wasn't just caused by issues with the approximation. I do think that it's cool to demonstrate that celerite models have the support to capture structure like an exp-squared and that you can get consistent results and I think that that could go in a section called something like "kernel design" but I don't really want to include these fitting formulas in the paper. If a user really wants to use them then they can build it themselves - then at least they know what they're getting themselves into and we don't have to support it. |
@dfm I see your point; I'm fine with whatever you see fit. |
Nice job on the exponential squared example! |
Thanks! The text needs work but I think that the example shows what we want. |
@dfm I moved Sturm's theorem discussion to appendix, but didn't add the J=2 formulae since they are somewhat complicated (involving the solutions of the cubic equation, and requiring the introduction of additional notation), and redundant since Sturm's theorem should work in that case as well. |
Thanks! |
Things to do before we send the manuscript around:
Add a section about parameterization and API? Optional.The text was updated successfully, but these errors were encountered: