Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMF lower limit, variables defined during setup #145

Open
bd-j opened this issue Feb 28, 2021 · 0 comments
Open

IMF lower limit, variables defined during setup #145

bd-j opened this issue Feb 28, 2021 · 0 comments
Assignees

Comments

@bd-j
Copy link
Collaborator

bd-j commented Feb 28, 2021

The FSPS setup module reads imf_lower_bound from the imf_lower_limit variable at instantiation and uses the former variable when computing the weight of the lowest mass isochrone point. However, only the latter variable is accessible through python-fsps. In practice this means that changing imf_lower_limit to any value below the mass of the lowest-mass isochrone point leads to incorrect calculation of its weight.

The best fix for this is probably in fsps itself, but it's probably worth checking sps_setup.f90 for any similar cases.

@bd-j bd-j self-assigned this Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant