use units_per_em to scale CFF font matrix #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dfrg could you review this when you have time? |
|
Yes, sorry for the delay. At a glance, I do think the CFF table should just read upem again rather than feeding the full metrics struct through. If you make that change, I’ll go ahead and merge. |
create CFF glyphs based on units_per_em parse font head for upem in cff from_font Defaults to 1000 if head is None.
danielronnkvist
force-pushed
the
cff-font-matrix-upem
branch
from
a61375e
to
0a04027
Compare
|
@dfrg I've made an update now where the CFF table reads upem again and removed the passing of metrics. |
|
This looks great. Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered a couple of fonts that were using CFF to generate paths, but their settings was a bit unusual by having the em size set to 2000. That resulted in swash rendering the fonts in half their real size. By scaling the
font_matrixusing the font'sunits_per_eminstead they where rendered correctly.I'm a bit uncertain if I should pass the metrics along the functions to where it's needed or if it's better to read the
units_per_emby parsing the data once again. Any recommendations?Closes #27