Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust Nightly 4-1-2023 and forward breaks swash. #34

Closed
genusistimelord opened this issue Apr 9, 2023 · 2 comments · Fixed by #35
Closed

Rust Nightly 4-1-2023 and forward breaks swash. #34

genusistimelord opened this issue Apr 9, 2023 · 2 comments · Fixed by #35

Comments

@genusistimelord
Copy link

genusistimelord commented Apr 9, 2023 •
edited
Loading

just a heads up On nightly 4-1-2023
rust-lang/rust@22a7a19

is causing issues in swash in debug mode
all newer nightlys will have the same issue. I am unsure if i should Report it here to fix the alignment issue or to rust lang....

the error occurs here due to the new alignment check.
https://github.com/dfrg/swash/blob/master/src/internal/parse.rs#L452
@RagibHasin
Copy link
Contributor

I just hit it too.

Anyway, why pointer::read_unaligned is not used here? Does USE_UNALIGNED_READS_LE not imply that read_unaligned should be used?

@RagibHasin
Copy link
Contributor

Just tried read_unaligned and it fixed the issue. Should I make a PR?

@RagibHasin RagibHasin mentioned this issue Apr 22, 2023
Merged
@dfrg dfrg closed this as completed in #35 Apr 30, 2023
@Rodrigodd Rodrigodd mentioned this issue Jun 9, 2023
Closed
@MinusGix MinusGix mentioned this issue Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix using proper unaligned read RagibHasin/swash
2 participants
@genusistimelord @RagibHasin