Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8 & PostgreSQL reflector #380

Closed
jkuchar opened this issue Dec 21, 2020 · 2 comments · Fixed by #381
Closed

PHP8 & PostgreSQL reflector #380

jkuchar opened this issue Dec 21, 2020 · 2 comments · Fixed by #381

Comments

@jkuchar
Copy link
Contributor

jkuchar commented Dec 21, 2020

Version: 4.2.0

Bug Description

PHP 8 changed inter-type comparisons. This led to this code to fail:

	public function __construct(Dibi\Driver $driver, string $version)
	{
                // $version = "11.10 (Debian 11.10-1.pgdg90+1)"
		if ($version < 7.4) {
			throw new Dibi\DriverException('Reflection requires PostgreSQL 7.4 and newer.');
		}
		$this->driver = $driver;
		$this->version = $version;
	}
@dg
Copy link
Owner

dg commented Dec 21, 2020

Can you send PR?

@jkuchar jkuchar mentioned this issue Dec 22, 2020
Merged
@jkuchar
Copy link
Contributor Author

jkuchar commented Dec 22, 2020

Done.

@dg dg closed this as completed in #381 Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PostgreReflector: removed version check jkuchar/dibi
2 participants
@jkuchar @dg