Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning on the .htdeployment file? #147

Closed
cr1st1p opened this issue Aug 26, 2021 · 0 comments
Closed

versioning on the .htdeployment file? #147

cr1st1p opened this issue Aug 26, 2021 · 0 comments

Comments

@cr1st1p
Copy link

cr1st1p commented Aug 26, 2021

Version: git head and 3.4.0

Bug Description

I think there might be some structure change of the file .htdeployment between what's published today as .phar file (3.4.0) and git main branch. Which crashes the program.

Steps To Reproduce

Because I had to fix the file:/// uri issue, I did a local git clone and ran at some point a ftps:// deployment.
Then I tried again via latest downloaded .phar file - and it crashed with

Live mode        
Connecting to server        
Error: gzinflate(): data error in phar:///home/cristi/src/dermaline/deployment.phar/src/Deployment/Deployer.php:2 

After renaming the .htdeployment file away, it worked.

Expected Behavior

Code should recognize file format of that file and work with both old and new format. And if version is not recognized - give a more meaningful error.
But again - I haven't checked the code, so it is just a supposition.

Possible Solution

@cr1st1p cr1st1p changed the title versioning on the .htdeployment file versioning on the .htdeployment file? Aug 26, 2021
@dg dg closed this as completed in 608f441 Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant