Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Improvement Ideas #11

Closed
haydenbr opened this issue Dec 4, 2018 · 1 comment
Closed

Test Improvement Ideas #11

haydenbr opened this issue Dec 4, 2018 · 1 comment

Comments

@haydenbr
Copy link

haydenbr commented Dec 4, 2018

Just a couple thoughts to improve the tests if you're still working on this.

  1. commit the seed data. Probably doesn't make a huge difference, but it would ensure that every run of the test was using the exact same randomly generating data. (On a similar thought, I wonder what would happen if all your test data was zeroes)
  2. It would be a little more interesting if you ran each method on each data set size multiple times
  3. If you ran every single test run in a brand new Docker container, it would probably get you a little more consistency. It would take a lot more effort and may not be worth, but it would be interesting.

I might pitch in and try my hand at one or all of these. Regardless of the results, it's an interesting idea you had to think to test these things.

@dg92
Copy link
Owner

dg92 commented Aug 21, 2019

@haydenbr, thanks for the suggestion, I have started looking into the repo again, will keep you updated, if you have done the above by yourself then MR is welcomed.

@haydenbr haydenbr closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants