Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream sqljdbc zip file is fubar #448

Open
rgl opened this issue Nov 28, 2022 · 2 comments
Open

upstream sqljdbc zip file is fubar #448

rgl opened this issue Nov 28, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@rgl
Copy link

rgl commented Nov 28, 2022

Did you notice that the upstream zip file has a broken path? By any change did you report this upstream?

For example, the English variant at https://download.microsoft.com/download/d/1/9/d194dc5c-4db6-4fb6-8ba2-219c93272b7b/sqljdbc_11.2.0.0_enu.zip:

image

And because of this, chocolatey installs the package at in a path with a strange character (\e) C:\Program Files\Microsoft JDBC DRIVER for SQL Server\sqljdbc_11.2enu instead of the expected C:\Program Files\Microsoft JDBC DRIVER for SQL Server\sqljdbc_11.2\enu:

image

@dgalbraith
Copy link
Owner

@rgl thanks for flagging the issue - I had not picked this up/reported on this.

@David-Engel thanks for raising upstream.

Interestingly as per the observed behavior this is only an issue for 7z - all of the OS standard archive handling functions are fine including the PowerShell Expand-Archive which resolves the version / path separator character as a \ rather than the seen by 7-zip.

image

Looks like an update is tagged for a fix as a 12.2.0 milestone so I will have a look locally and see if I can issue an update that detects this post install and corrects.

It is not really possible to capture upfront as the use of 7-zip is embedded directly in the Chocolatey functions, and non-use of the Chocolatey functions in packages is not compliant from a packaging perspective.

I should be able to get an update in for the 11.2 series as 11.2.1.0 has been published at source and has fortunately (in this instance in any case) failed package validation for other reasons.

@David-Engel any suggestions on how far back I should look to try and apply this fix?

@dgalbraith dgalbraith self-assigned this Dec 5, 2022
@dgalbraith dgalbraith added the bug Something isn't working label Dec 5, 2022
@David-Engel
Copy link

any suggestions on how far back I should look to try and apply this fix?

@dgalbraith It goes back all the way to 8.2, when the JDBC driver switched from self-extracting exe to zip. It should be "fixed" from our end in the next release. It was just a matter of changing a backslash to a forward slash in the ant script that builds the zip file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants