Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github identifier format in docs/source/conf.py #230

Closed
NGC2023 opened this issue May 11, 2024 · 1 comment
Closed

Github identifier format in docs/source/conf.py #230

NGC2023 opened this issue May 11, 2024 · 1 comment

Comments

@NGC2023
Copy link

NGC2023 commented May 11, 2024

Hi,
I'm currently working on packaging opt_einsum v3.3.0 for Debian. While reviewing the code, I noticed an issue with the Github identifier format in docs/source/conf.py. I've prepared a patch to address this problem.

--- a/docs/source/conf.py
+++ b/docs/source/conf.py
@@ -395,8 +395,8 @@ def setup(app):
app.connect('autodoc-skip-member', autodoc_skip_member)

extlinks = {
-- 'issue': ('https://github.com/dgasmith/opt_einsum/issues/%s', 'GH#'),
-- 'pr': ('https://github.com/dgasmith/opt_einsum/pull/%s', 'GH#')
++ 'issue': ('https://github.com/dgasmith/opt_einsum/issues/%s', 'GH#%s'),
++ 'pr': ('https://github.com/dgasmith/opt_einsum/pull/%s', 'GH#%s')
}

@dgasmith
Copy link
Owner

@NGC2023 Thank you for the report, fortunately we have moved to mkdocs which has removed these files. We are currently preparing for another release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants