Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version problem #37

Closed
battuashwik opened this issue Jul 21, 2013 · 5 comments
Closed

version problem #37

battuashwik opened this issue Jul 21, 2013 · 5 comments

Comments

@battuashwik
Copy link

Do not use ~v0.4.10 as it has handlebars 1.0.0 which is not compatible with the present version of ember ( rc-6 ) and gives an error.

For now ~0.4.9 is the right version.

@mixonic
Copy link

mixonic commented Jul 23, 2013

@dgeb would you accept a PR to use the handlebars npm library instead of packaging one internally?

@dgeb
Copy link
Owner

dgeb commented Jul 23, 2013

@battuashwik that is correct - I created v0.4.10 for those who want to work with ember-latest.

@mixonic sounds good to me - thanks in advance!

@mixonic
Copy link

mixonic commented Jul 23, 2013

@dgeb I looked at the situation and new understanding has come to light.

Basically, grunt-ember-templates is dependent on handlebars and on ember itself for the compiler. Though there is a npm module for handlebars, the one for ember is way out of date (pre2 or something). So an easy move is not possible.

Possible next steps: NPMize Ember again. Explore an idea I have about apps providing versioned JS files back to the NPM modules they have as dependencies. Include ember and handlebars runtime with grunt-ember-templates so it is at least easy to use one unified version.

Probable next steps: Weep over my beer.

@dgeb
Copy link
Owner

dgeb commented Jul 23, 2013

@mixonic It seems to me that declaring a peerDependency on ember, which then is dependent on handlebars, is the right approach. However, without reliable dependencies, I will join you for that beer 😢 🍻 😢

@dgeb
Copy link
Owner

dgeb commented Aug 13, 2013

I'm going to close this now, since I've added a note about versioning to the README. Basically, this plugin tracks ember-latest, so you may need an older version to work with a particular release of ember/handlebars.

The dependency issues that @mixonic and I discussed run a bit deeper and probably deserve a thread of their own.

@dgeb dgeb closed this as completed Aug 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants