Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for DKK symbol #51

Closed
mortenbock opened this issue Aug 16, 2017 · 2 comments
Closed

Documentation for DKK symbol #51

mortenbock opened this issue Aug 16, 2017 · 2 comments

Comments

@mortenbock
Copy link

Hey :)

Do you have any documentation regarding the decision for formatting DKK symbol as "kr" and not "kr."?

Assert.That(subject.ToString(), Is.EqualTo("kr 5,00"), "Kroner symbol DOES not include dot. Mistake in Vista and newer.");

I'v been asked to change the formatting, and just want to make sure that we're doing the right thing.

@dgg
Copy link
Owner

dgg commented Aug 16, 2017

Hey...

I periodically double check formatting of currencies as provided by the .NET framework with external information. My main source of which is Wikipedia.

In this particular case I seem to recall I saw an article somewhere else in regards of DKK formatting and made me double check with wikipedia which, at that time, stated the currency sign was kr (without the trailing dot).

Since then, I have not checked it again, but I can see now that both the wikipedia page in English and Danish state that the symbol is kr. and that is consistent with the information provided by the Danmarks Nationalbank page.

I will issue a quick fix to save you from having to override all your calls to .ToString() and because it is the right thing to do 😉

Should not take long...

@dgg
Copy link
Owner

dgg commented Aug 16, 2017

fixed in 7ab4d8a (v5.1.4.0)

@dgg dgg closed this as completed Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants