Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interaction type and gene claim category if not already in DB #49

Closed
jsstevenson opened this issue Mar 24, 2022 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@jsstevenson
Copy link
Contributor

Currently, the base Importer class will raise an error if it encounters an interaction type or gene claim category that isn't already in the corresponding tables (see eg

def create_interaction_claim_type(interaction_claim, type)
)

We should (in separate issues) ensure that the normalization of the values going into those fields has satisfactory results -- but I don't think a normalized value should have to be manually added to any tables, so the constraints above should be removed, and if the value isn't already in the table, the importer should add it.

@jsstevenson jsstevenson added the enhancement New feature or request label Mar 24, 2022
@jsstevenson jsstevenson mentioned this issue Mar 25, 2022
39 tasks
@mcannon068nw mcannon068nw self-assigned this Apr 4, 2022
@mcannon068nw
Copy link
Contributor

applicable to gene claim categories, for interaction claim types perhaps a rake task is best

@jsstevenson
Copy link
Contributor Author

Cooler heads prevailed, and determined that no additional changes were necessary here

1 similar comment
@jsstevenson
Copy link
Contributor Author

Cooler heads prevailed, and determined that no additional changes were necessary here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants