Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global grpc ingress yields two host key entries #96

Closed
darkn3rd opened this issue Jun 21, 2023 · 0 comments · Fixed by #97
Closed

global grpc ingress yields two host key entries #96

darkn3rd opened this issue Jun 21, 2023 · 0 comments · Fixed by #97

Comments

@darkn3rd
Copy link
Contributor

STEPS TO REPRODUCE

helm template ./charts/dgraph --values -  <<EOF
fullNameOverride: jmdg
global:
  ingress:
    enabled: true
    alpha_hostname: alpha.example.com
    ingressClassName: alb
    annotations:
      alb.ingress.kubernetes.io/scheme: internet-facing
      alb.ingress.kubernetes.io/target-type: ip
  ingress_grpc:
    enabled: true
    alpha_grpc_hostname: grpc.example.com
    ingressClassName: alb
    annotations:
      alb.ingress.kubernetes.io/scheme: internet-facing
      alb.ingress.kubernetes.io/target-type: ip
EOF

ACTUAL RESULTS

---
# Source: dgraph/templates/global-ingress.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: release-name-dgraph-ingress
  labels:
    app: dgraph
    chart: dgraph-0.1.0
    component: alpha
    release: release-name
    heritage: Helm
  annotations:
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/target-type: ip
spec:
  ingressClassName: alb
  rules:
    - http:
        paths:
          - backend:
              service:
                name:  release-name-dgraph-alpha
                port:
                  number: 8080
            pathType: ImplementationSpecific
            path: /*
      host: alpha.example.com
---
# Source: dgraph/templates/global-ingress.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: release-name-dgraph-ingress-grpc
  labels:
    app: dgraph
    chart: dgraph-0.1.0
    component: alpha
    release: release-name
    heritage: Helm
  annotations:
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/target-type: ip
spec:
  ingressClassName: alb
  rules:
    - host: grpc.example.com
      http:
        paths:
          - backend:
              service:
                name:  release-name-dgraph-alpha
                port:
                  number: 9080
            pathType: ImplementationSpecific
            path: /*
      host: grpc.example.com

EXPTECTED RESULTS

The grpc should only have a single host key, e.g.

# Source: dgraph/templates/global-ingress.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: release-name-dgraph-ingress-grpc
  labels:
    app: dgraph
    chart: dgraph-0.1.0
    component: alpha
    release: release-name
    heritage: Helm
  annotations:
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/target-type: ip
spec:
  ingressClassName: alb
  rules:
    - http:
        paths:
          - backend:
              service:
                name:  release-name-dgraph-alpha
                port:
                  number: 9080
            pathType: ImplementationSpecific
            path: /*
      host: grpc.example.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant