Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear the unused variable tlsCfg #3937

Merged
merged 1 commit into from Sep 6, 2019
Merged

Clear the unused variable tlsCfg #3937

merged 1 commit into from Sep 6, 2019

Conversation

gitlw
Copy link

@gitlw gitlw commented Sep 6, 2019 •
edited by manishrjain

This change is Reviewable

@gitlw gitlw requested review from manishrjain and a team as code owners September 6, 2019 21:25
pullrequest[bot]
pullrequest bot reviewed Sep 6, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.

@gitlw you can click here to see the review status or cancel the code review job.

pullrequest[bot]
pullrequest bot reviewed Sep 6, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Message
✅ The description of this pull request is blank. Adding a high-level summary will help our reviewers provide better feedback.

martinmr
martinmr approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@gitlw gitlw merged commit 7f4d96f into master Sep 6, 2019
@gitlw gitlw deleted the gitlw/clear_unused_tlsCfg branch September 6, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pullrequest pullrequest[bot] pullrequest left review comments

@martinmr martinmr martinmr approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gitlw @martinmr