Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated methods. #4076

Merged
merged 1 commit into from Sep 27, 2019
Merged

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Sep 27, 2019

ErrorDesc in the grpc is deprecated. It's been replaced by the
recommended methods.


This change is Reviewable

ErrorDesc in the grpc is deprecated. It's been replaced by the
recommended methods.
@martinmr martinmr requested review from manishrjain and a team as code owners September 27, 2019 01:16
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@martinmr you can click here to see the review status or cancel the code review job.

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. Should ensure there is no other similar usages that need updating in the codebase.


Reviewed with ❤️ by PullRequest

@martinmr martinmr merged commit 7572578 into master Sep 27, 2019
@martinmr martinmr deleted the martinmr/grpc-deprecated branch September 27, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants