Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default ratio of traces from 1 to 0.01. #5405

Merged
merged 1 commit into from May 12, 2020

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented May 9, 2020

Opencensus traces are taking a lot of memory.


This change is Reviewable

Opencensus traces are taking a lot of time.
@martinmr martinmr requested review from manishrjain and a team as code owners May 9, 2020 01:00
Copy link
Contributor

@parasssh parasssh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)

a discussion (no related file):
:lgtm:


@martinmr martinmr merged commit a2c9e16 into master May 12, 2020
@martinmr martinmr deleted the martinmr/default-traces branch May 12, 2020 15:32
martinmr added a commit that referenced this pull request May 12, 2020
Opencensus traces are taking a lot of memory.
martinmr added a commit that referenced this pull request May 12, 2020
Opencensus traces are taking a lot of memory.
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
Opencensus traces are taking a lot of memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants