Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ludicrous mode to live loader #5419

Merged
merged 3 commits into from
May 13, 2020
Merged

Conversation

harshil-goel
Copy link
Contributor

@harshil-goel harshil-goel commented May 11, 2020

Introduces ludicrous mode to live loader. It significantly reduces the memory utilized by live loader, and marginally increases ingestion speed.


This change is Reviewable

@harshil-goel harshil-goel requested a review from a team as a code owner May 11, 2020 13:45
@github-actions github-actions bot added the area/live-loader Issues related to live loading. label May 11, 2020
Copy link
Contributor

@ashish-goswami ashish-goswami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arijitAD, @gja, and @manishrjain)

Copy link

@arijitAD arijitAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arijitAD, @gja, and @manishrjain)

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Mention that this should only be done if Alpha is under ludicrous mode.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gja)

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

One comment that doesn't need to be addressed in this PR, but is there a way to verify that the alpha is in fact in ludicrous mode (the health endpoint perhaps) and exiting if that's not the case.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gja)

@harshil-goel harshil-goel merged commit 02c90d2 into master May 13, 2020
ashish-goswami pushed a commit that referenced this pull request May 26, 2020
* Adds ludicrous mode to live loader

* changed msg

(cherry picked from commit 02c90d2)
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
* Adds ludicrous mode to live loader

* changed msg
@joshua-goldstein joshua-goldstein deleted the harshil-goel/live-ludicrous branch August 11, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/live-loader Issues related to live loading.
Development

Successfully merging this pull request may close these issues.

None yet

5 participants