fix(Dgraph): Parse Content-Type in headers properly #6370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajeetdsouza
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
ajeetdsouza
force-pushed
the
charset-fix
branch
from
94888e6
to
b6283b4
Compare
parasssh
approved these changes
Sep 3, 2020
ajeetdsouza
force-pushed
the
charset-fix
branch
from
5ec0c72
to
aad1f3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-2227.
A request sent to a query or mutation handler with the header
Content-Type: application/json; charset=utf-8fails even though it is perfectly valid. This PR fixes parsing of theContent-Typeheader.Currently, I've added a check -
charset, if defined, must beutf-8. We may or may not want to remove that check.This change is