Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(release/v20.03) Update nextRaftId when starting a node with a raftId > 0 #6598

Merged
merged 1 commit into from Oct 4, 2020
Merged

(release/v20.03) Update nextRaftId when starting a node with a raftId > 0 #6598

merged 1 commit into from Oct 4, 2020

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Sep 29, 2020 •
edited by dgraph-bot

If we don't do that, the next node that starts with an ID of zero
(auto-assign) will be assigned an existing ID.

DGRAPH-2496

(cherry picked from commit a4f21f4)

This change is Reviewable

Docs Preview: Dgraph Preview

@martinmr
(release/v20.03) Update nextRaftId when starting a node with a raftId…
976fdab 
… > 0.

If we don't do that, the next node that starts with an ID of zero
(auto-assign) will be assigned an existing ID.

DGRAPH-2496

(cherry picked from commit a4f21f4)
@martinmr martinmr requested review from manishrjain and a team as code owners September 29, 2020 13:39
@martinmr
Copy link
Contributor Author

martinmr commented Oct 3, 2020

Tests pass.

@parasssh parasssh merged commit 33c6f4e into release/v20.03 Oct 4, 2020
@parasssh parasssh deleted the martinmr/cp-nextid03 branch October 4, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinmr @parasssh