Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added comment docstring for ExportInput format #6991

Merged
merged 2 commits into from Dec 9, 2020

Conversation

darkn3rd
Copy link
Contributor

@darkn3rd darkn3rd commented Nov 25, 2020

Added docstring comment for ExportInput { format }.


This change is Reviewable

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Nov 25, 2020
@netlify
Copy link

netlify bot commented Nov 25, 2020

Deploy preview for dgraph-docs ready!

Built with commit 36ddb4f

https://deploy-preview-6991--dgraph-docs.netlify.app

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai, @darkn3rd, @MichaelJCompton, and @pawanrawal)


graphql/admin/admin.go, line 214 at r1 (raw file):

Data format for the export, e.g. json or rdf

Data format for the export, e.g., "rdf" or "json" (default: "rdf")

Copy link
Contributor Author

@darkn3rd darkn3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai, @MichaelJCompton, and @pawanrawal)


graphql/admin/admin.go, line 214 at r1 (raw file):

Previously, danielmai (Daniel Mai) wrote…
Data format for the export, e.g. json or rdf

Data format for the export, e.g., "rdf" or "json" (default: "rdf")

updated.

@darkn3rd darkn3rd requested review from danielmai and removed request for pawanrawal and MichaelJCompton November 25, 2020 21:13
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @darkn3rd)

@darkn3rd darkn3rd merged commit 072b03e into master Dec 9, 2020
@darkn3rd darkn3rd deleted the joaquin/exportinput-format branch December 9, 2020 17:38
darkn3rd added a commit that referenced this pull request Dec 10, 2020
* fix: added comment docstring for ExportInput format

(cherry picked from commit 072b03e)
darkn3rd added a commit that referenced this pull request Dec 10, 2020
* fix: added comment docstring for ExportInput format

(cherry picked from commit 072b03e)
darkn3rd added a commit that referenced this pull request Dec 10, 2020
* fix: added comment docstring for ExportInput format

(cherry picked from commit 072b03e)
darkn3rd added a commit that referenced this pull request Dec 10, 2020
* fix: added comment docstring for ExportInput format

(cherry picked from commit 072b03e)
darkn3rd added a commit that referenced this pull request Dec 10, 2020
* fix: added comment docstring for ExportInput format

(cherry picked from commit 072b03e)
darkn3rd added a commit that referenced this pull request Dec 10, 2020
* fix: added comment docstring for ExportInput format

(cherry picked from commit 072b03e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants