feat(sroar): Bring sroar to Dgraph #7840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
requested review from
manishrjain,
pawanrawal and
vvbalaji-dgraph
as code owners
manishrjain
approved these changes
May 20, 2021
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ahsanbarkati, @pawanrawal, and @vvbalaji-dgraph)
posting/list.go, line 642 at r1 (raw file):
codec.RemoveRange(bm, 0, maxUid) glog.Infof("bm before iteration: %v\n", bm.ToArray())
remove?x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces roaring64 with sroar in Dgraph. A bunch of things might slow down after this change because we are yet to optimize sroar's functionalities.
This change is