Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way metrics are handled for deletions. #111

Merged
merged 6 commits into from
Dec 18, 2019

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Dec 10, 2019

This change is Reviewable

balaji added 2 commits December 11, 2019 17:21
Signed-off-by: balaji <balaji@dgraph.io>
Signed-off-by: balaji <balaji@dgraph.io>
Copy link
Contributor Author

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Feel free to merge. One comment.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @jarifibrahim)


policy.go, line 294 at r2 (raw file):

		p.metrics.add(keyUpdate, key, 1)
		p.metrics.add(costAdd, key, ^uint64(uint64(prev)-1))
		p.metrics.add(costAdd, key, uint64(cost))

Do it in one op.

Signed-off-by: balaji <balaji@dgraph.io>
Copy link
Contributor

@poonai poonai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jarifibrahim)

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r3.
Dismissed @manishrjain from a discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


policy.go, line 294 at r2 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Do it in one op.

Done by @balajijinnah

@poonai poonai merged commit 8350826 into master Dec 18, 2019
@joshua-goldstein joshua-goldstein deleted the mrjn/fix-metrics-for-del branch September 15, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants