Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus metrics for memory usage in bytes #140

Closed
bzon opened this issue Feb 20, 2020 · 3 comments
Closed

Prometheus metrics for memory usage in bytes #140

bzon opened this issue Feb 20, 2020 · 3 comments
Labels
area/integrations Related to integrations with other projects. area/tools Issues related to maintenance tools and CLI. benchmark kind/feature Something completely new we should consider. priority/P2 Somehow important but would not block a release. status/accepted We accept to work on it.

Comments

@bzon
Copy link

bzon commented Feb 20, 2020

It would be really helpful if we expose this as a Prometheus metric.
@shekarm shekarm added area/integrations Related to integrations with other projects. area/tools Issues related to maintenance tools and CLI. benchmark kind/feature Something completely new we should consider. status/needs-attention This issue needs more eyes on it, more investigation might be required before accepting/rejecting it labels Feb 21, 2020
@martinmr
Copy link
Contributor

Yeah, not a bad idea to have the option to export this metric (and probably all the other ones) integrated with Prometheus. I'll look into it.

@martinmr martinmr added status/accepted We accept to work on it. and removed status/needs-attention This issue needs more eyes on it, more investigation might be required before accepting/rejecting it labels Feb 21, 2020
@bzon
Copy link
Author

bzon commented Feb 21, 2020

Cool! Probably look up opencensus (soon to be opentelemetry) so tracing can be enabled as well.

If the Cache can be an interface, then it would be easier to just instrument metrics at the middleware level.

@martinmr martinmr added the priority/P2 Somehow important but would not block a release. label Feb 21, 2020
@minhaj-shakeel
Copy link
Contributor

Github issues have been deprecated.
This issue has been moved to discuss. You can follow the conversation there and also subscribe to updates by changing your notification preferences.

drawing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/integrations Related to integrations with other projects. area/tools Issues related to maintenance tools and CLI. benchmark kind/feature Something completely new we should consider. priority/P2 Somehow important but would not block a release. status/accepted We accept to work on it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@martinmr @shekarm @bzon @minhaj-shakeel