Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating selectedIds fires onNodeSelect #131

Closed
sandro768 opened this issue Jun 27, 2023 · 3 comments
Closed

updating selectedIds fires onNodeSelect #131

sandro768 opened this issue Jun 27, 2023 · 3 comments
Labels
help wanted Extra attention is needed wontfix This will not be worked on

Comments

@sandro768
Copy link
Contributor

sandro768 commented Jun 27, 2023

Describe the bug
docs of onNodeSelect says onNodeSelect called when a node was manually selected/deselected but
updating selectedIds array fires onNodeSelect

I've created a sandbox as an example. button click fires react-router-dom's useNavigate hook, after the navigation selectedIds will be updated (as its state depends on query params) therefor onNodeSelect will be fired even though I haven't selected/deselected anything manually

To Reproduce
Steps to reproduce the behavior:

  1. Visit sandbox
  2. open the console to observe
  3. Enter https://pmpsq8.csb.app/folders/2 in URL of the sandbox
  4. Click(expand) Node modules
  5. Click button which is at the top of the page
  6. you will see that after the navigation onNodeSelect gets fired
@dgreene1 dgreene1 added the help wanted Extra attention is needed label Jun 27, 2023
@dgreene1
Copy link
Owner

We’re open to a PR for this.

@stale
Copy link

stale bot commented Aug 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 26, 2023
@stale
Copy link

stale bot commented Sep 3, 2023

This issue was closed automatically since it was marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this as completed Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants