Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to disable selection propagation #92

Closed
mellis481 opened this issue Mar 21, 2023 · 6 comments
Closed

Remove ability to disable selection propagation #92

mellis481 opened this issue Mar 21, 2023 · 6 comments
Labels
wontfix This will not be worked on

Comments

@mellis481
Copy link
Collaborator

mellis481 commented Mar 21, 2023

As a maintainer, I'm logging this "feature request" because it's something my team plans on executing in the foreseeable future, but I want there to be visibility to the consumers of this library. Please provide feedback if you have any regarding this issue.

Problem Statement
Disabling selection propagation upward and/or downward creates serious usability and accessibility issues.

Core Principles
There are two principles for a tree component that must be upheld with regard to parent nodes to ensure good usability and accessibility. A parent node should:

  1. always correctly inform the checked status of its children.
  2. provide a convenient means for selecting/unselected children.

Allowing selection propagation to be disabled in either direction goes against both of those principles.

Details
The usability and a11y issues are most easily seen when selection propagation is disabled in either direction and a parent node is collapsed. In this first example, if "Fruits" was collapsed, a user would believe no children were selected even though one or even all could be.

image

In this second example, if "Fruits" was collapsed, a user would believe all children would be selected even though none are.

image

From an accessibility standpoint, looking again at the first example, if a screen reader user focuses the "Fruits" checkbox, the screen reader would announced "Fruits not checked collapsed 1 of 3 level 1". This would have the user think "Since 'Fruits' is collapsed, that must mean it has children, but since it was announced as 'not checked', neither 'Fruits' nor any children are checked."

For these reasons, the ability to disable selection propagation should be removed.

@stale
Copy link

stale bot commented May 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 20, 2023
@stale
Copy link

stale bot commented May 27, 2023

This issue was closed automatically since it was marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this as completed May 27, 2023
@mellis481 mellis481 removed the wontfix This will not be worked on label Jun 26, 2023
@mellis481 mellis481 reopened this Jun 26, 2023
@mellis481 mellis481 pinned this issue Jun 26, 2023
@stale
Copy link

stale bot commented Aug 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 25, 2023
@stale
Copy link

stale bot commented Sep 2, 2023

This issue was closed automatically since it was marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this as completed Sep 2, 2023
@mellis481 mellis481 reopened this Oct 19, 2023
@stale stale bot removed the wontfix This will not be worked on label Oct 19, 2023
Copy link

stale bot commented Dec 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 18, 2023
Copy link

stale bot commented Dec 26, 2023

This issue was closed automatically since it was marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this as completed Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant