Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Video Doorbell 4" and "Spotlight Cam Plus" cameras showing "Unknown Model" #1335

Closed
1 task done
jarodwsams opened this issue Oct 17, 2023 · 1 comment
Closed
1 task done
Labels
bug Something isn't working

Comments

@jarodwsams
Copy link
Contributor

jarodwsams commented Oct 17, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe The Bug

I have both a Video Doorbell 4 and a Spotlight Cam Plus that are showing "Unknown Model". I know from another integration that I've contributed to that the model identifier for both devices have newer device type strings (doorbell_oyster for the Doorbell 4 and cocoa_spotlight for the Spotlight Cam Plus). Neither of those device types are currently included in the ring-types.ts file.

I have a Stick Up Cam that shows the correct model name. In my Hubitat environment, using the "Unofficial Ring Integration", I had to add the cocoa_spotlight type for the integration to pick up the camera, which it promptly did after that modification to the source code for that integration.

To Reproduce

Set up an MQTT environment with Ring-MQTT (https://github.com/tsightler/ring-mqtt).
Make sure you've got a Ring Video Doorbell 4 and/or a Ring Spotlight Cam Plus set up in your Ring account.
Note that both devices show "Unknown Model" in the device info in Home Assistant (screenshots).

Expected behavior

Both cameras should show the correct model names ("Doorbell 4" for the doorbell_oyster device and "Spotlight Cam Plus" for the cocoa_spotlight device)

Relevant log output

No response

Screenshots

image
image

Additional context

I have already forked the main branch and made the necessary modifications to ring-types.ts. The PR can be found here (PR 1334)

OS

Ubuntu Server / Docker

Node.js Version

v18.17.1

NPM Version

v9.1.2

ring-client-api

v12.0.1

Operating System

Docker

@jarodwsams jarodwsams added the bug Something isn't working label Oct 17, 2023
@dgreif
Copy link
Owner

dgreif commented Oct 17, 2023

Thanks for getting these added! The PR looks good, so I'll get that merged and included in the next release

@dgreif dgreif closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants