Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chime support enhancements #720

Closed
tsightler opened this issue Aug 3, 2021 · 2 comments
Closed

Chime support enhancements #720

tsightler opened this issue Aug 3, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@tsightler
Copy link
Collaborator

Feature Request

Description

Hi @dgreif , thanks for your continued support of this API and thank you for your consideration of these two minor requests below.

I've recently had a few request to support wifi status with chimes in ring-mqtt but currently this isn't available via the API. I'd like to see a "getHealth" function for chimes similar to the one for cameras.

Also, as a super minor enhancement, adding support for chime_v2 and chime_pro_v2 for more correct model numbers might be nice as well.

Describe the solution you'd like

I think you should be able to just copy the getHealth() function from cameras as the behavior is basically identical.

Describe alternatives you've considered

I actually implemented my own function to get the health status via a call to restClient directly and it works great, but a getHealth() function would be nice for consistency between cameras and chimes I think. This is the code I'm currently using:

const chimeHealth = await this.device.restClient.request({
    url: clientApi(`chimes/${this.device.id}/health`),
    responseType: 'json'
})

I've also manually addressed the model name in my code as well, it's a really minor issue of course.

@tsightler tsightler added the enhancement New feature or request label Aug 3, 2021
@dgreif dgreif closed this as completed in d78f92b Aug 6, 2021
@dgreif
Copy link
Owner

dgreif commented Aug 6, 2021

@tsightler all of your requests should be available in 9.20.0. Let me know if you run into any issues!

@tsightler
Copy link
Collaborator Author

@dgreif Thanks you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants