Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any necessary to lock when update params? #36

Open
Ranglage opened this issue Oct 14, 2020 · 1 comment
Open

Is there any necessary to lock when update params? #36

Ranglage opened this issue Oct 14, 2020 · 1 comment

Comments

@Ranglage
Copy link

It seems doesn't get lock when update network params in SharedAdam.
However, isn't there process safety problem without a lock?

@dgriff777
Copy link
Owner

Yes, there is possibility for bad updates if race condition occurs but such bad updates are quickly overwritten by new incoming updates. Although this can look to be as a disadvantage to this method, the use of locks are substantially time consuming. Overall, any negative is far outweighed by the increase in speed of updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants