Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PUSH_PROMISE? #7

Closed
dgrr opened this issue Feb 15, 2021 · 5 comments
Closed

Support PUSH_PROMISE? #7

dgrr opened this issue Feb 15, 2021 · 5 comments

Comments

@dgrr
Copy link
Owner

dgrr commented Feb 15, 2021

I'd be nice if routers or framework implementations like gramework or fiber could choose to push some content before being asked to. Think about the possible implementation.

@zMrKrabz
Copy link

There was a rejected pull request here, that I added to my fhttp library, which is a fork of net/http.

@dgrr
Copy link
Owner Author

dgrr commented Jun 18, 2021

Hello. Thanks for the info. Why it was rejected? I see no apparent reason

@zMrKrabz
Copy link

Think it is because Chrome was the only browser that supported ENABLE_PUSH, but is removing it in the near future

@dgrr
Copy link
Owner Author

dgrr commented Jun 22, 2021

The implementation is quite difficult for frameworks in fasthttp or even net/http, so I can understand is not fully supported. I will not support it for now, but I'll leave the issue open in case someone has a suggestion

@dgrr
Copy link
Owner Author

dgrr commented Aug 19, 2021

Yep, it won't support PUSH_PROMISE so far

@dgrr dgrr closed this as completed Aug 19, 2021
@dgrr dgrr mentioned this issue Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants