Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification force formatting settings #1659

Closed
alfureu opened this issue Jun 28, 2023 · 3 comments · Fixed by #1660
Closed

Notification force formatting settings #1659

alfureu opened this issue Jun 28, 2023 · 3 comments · Fixed by #1660
Assignees
Labels
bug Something isn't working

Comments

@alfureu
Copy link

alfureu commented Jun 28, 2023

Describe the bug
Some of us have email clients where we have only 2 options to display the message body: text or HTML. This is particularly the case with the popular emClient email client. The issue is that with changedetection's email notification the message body is rearranged as non-structured text in both notification as text only or HTML.

Unfortunately the email client does not allow any formatting of the email whatsoever, making the tracking of changes impossible in the client.

With the general notification settings:

{{watch_title}} had a change...
{{watch_url}}


{{diff_added}}

one would expect to get the following email notification:

https://changedetection.io/CHANGELOG.txt
had a change...


(added ) HEAD / 2023-06-28 00:03:02 +0200:
(added ) - Fix - Watches werent falling back to global default formats correctly when required (#1656)

(added ) 0.43.1 / 2023-06-27 18:28:18 +0200:
(added ) - 0.43.1
(added ) - Bug fix - Notification settings were not cascading from global -> tags -> watch correctly in some cases (#1654)
(added ) - Bug - Fix watch clone (#1647)
(added ) - UI - Dont allow empty tag names (#1641)

but instead the email looks like this:

https://changedetection.io/CHANGELOG.txt had a change... ____________________________________________ (added ) HEAD / 2023-06-28 00:03:02 +0200: -(added ) Fix - Watches werent falling back to global default formats correctly when required (#1656) (added ) 0.43.1 / 2023-06-27 18:28:18 +0200: - 0.43.1 (added ) - Bug fix - Notification settings were not cascading from global -> tags -> watch correctly in some cases (#1654) (added ) - Bug - Fix watch clone (#1647) (added ) - UI - Dont allow empty tag names (#1641)

You can easily see that without any formatting it is extremely difficult to see the changes, additions...

Version
v0.43.1

To Reproduce

Steps to reproduce the behavior:

  1. Set any Text or HTML notification in changedetection
  2. have the wrong email client

Expected behavior
Would it be please possible to introduce some formatting elements into the notifications? For example, I would really appreciate if the same formatting would show up (with forced left indentation and forced CR LFs) as under the Diff button in changedetection's web frontend.

@Arathen
Copy link

Arathen commented Jun 29, 2023

Just to add, this seems to be something which was introduced only with 0.43.1 this week. Prior to this version a diff rendered correctly, while after it does not. Im using Protonmail via a browser, and that has the same issue.

Before:
image

After:
image

Diffs from different watches obviously. Both are Github tag pages, albeit different apps.

Thanks.

@dgtlmoon dgtlmoon added bug Something isn't working and removed triage labels Jun 30, 2023
@dgtlmoon
Copy link
Owner

Agreed- there is some issue, looking into it

@dgtlmoon
Copy link
Owner

kinda weird thing, when I select HTML I get the two versions (which is correct) but the HTML one has no <br> etc


--===============4993939228724319407==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

fallback-body http://localhost:5005/test-endpoint had a change. --- (change=
d) Which is across multiple lines (into) which has this one new line ---
--===============4993939228724319407==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

fallback-body http://localhost:5005/test-endpoint had a change.
---
(changed) Which is across multiple lines
(into) which has this one new line
---

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants