Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magit integration #19

Closed
bbatsov opened this issue Apr 14, 2014 · 3 comments
Closed

Magit integration #19

bbatsov opened this issue Apr 14, 2014 · 3 comments

Comments

@bbatsov
Copy link

bbatsov commented Apr 14, 2014

I've noticed that highlights are not removed after committing from magit. I guess this is related to this section of the README:

If you're using some package other than vc to commit changes, it might not run vc-checkin-hook after commits. In that case, you'll need to either add diff-hl-update to the hook it does run, or advise some function that's called in the buffer after its state has changed.

Given, magit's popularity, however, doesn't it make sense to support it out-of-the-box?

@dgutov
Copy link
Owner

dgutov commented Apr 14, 2014

Does it have a hook I can use?

@bbatsov
Copy link
Author

bbatsov commented Apr 14, 2014

Seems it doesn't magit/magit#603 I'll ask @tarsius for details.

@dgutov dgutov closed this as completed in a311beb Apr 16, 2014
@dgutov
Copy link
Owner

dgutov commented Apr 16, 2014

That should do it. Please see how it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants