Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with sopel-rep's karma commands #39

Open
dgw opened this issue Jul 1, 2017 · 0 comments
Open

Add compatibility with sopel-rep's karma commands #39

dgw opened this issue Jul 1, 2017 · 0 comments
Assignees

Comments

@dgw
Copy link
Owner

dgw commented Jul 1, 2017

This is a small step beyond just validating nicks against the character set allowed. sopel-rep's karma commands use ++ and -- appended to a nickname. + is not valid in nicks. The issue is deciding whether to bomb nick-- or nick, probably by checking if nick-- is present and falling back to nick if not. (Which means .bomb nick--- would also work to downrep and bomb nick- at once.)

I've proved the idea of simply importing the sopel-rep module's verification function in tests using sopel-duel, so that's probably the way to go. (I might want to rewrite the rep module using proper encapsulation before doing this, though.)

@dgw dgw added the enhancement label Jul 1, 2017
@dgw dgw self-assigned this Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant