Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout with "0 seconds" remaining shouldn't be possible #41

Closed
dgw opened this issue Aug 25, 2017 · 0 comments · Fixed by #52
Closed

Timeout with "0 seconds" remaining shouldn't be possible #41

dgw opened this issue Aug 25, 2017 · 0 comments · Fixed by #52
Assignees

Comments

@dgw
Copy link
Owner

dgw commented Aug 25, 2017

Due to how Python handles floating point numbers when interpolated into strings, the remaining seconds are truncated at the decimal point (not rounded). This can lead to the user being told to wait 0 more seconds before bombing again / performing .bomboff.

Timer code should round the value up to the next integer for display, so even if there's less than a second left it still appears as "1 second".

@dgw dgw self-assigned this Aug 25, 2017
dgw added a commit that referenced this issue Jun 7, 2020
@dgw dgw closed this as completed in #52 Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant