Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce types #29

Open
2 of 3 tasks
ColeDCrawford opened this issue Nov 10, 2022 · 0 comments
Open
2 of 3 tasks

Enforce types #29

ColeDCrawford opened this issue Nov 10, 2022 · 0 comments
Assignees

Comments

@ColeDCrawford
Copy link
Collaborator

ColeDCrawford commented Nov 10, 2022

Next step after #11 is to enforce types to a greater or lesser degree with something like MyPy or Pydantic. Here's a list of options: https://github.com/ethanhs/python-typecheckers.

I don't have much personal experience with any of the above options; I use pyright through pylance in VS Code as the default,. I've heard the most about mypy and pydantic. pytype also looks intriguing. Maybe a spike to explore the top few options and then implement in precommit and CI?

  • manually run a checker and clean up types in the code
  • preliminary mypy checking in CI ; documented in readme but not otherwise enforced
  • implement pre-commit check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants