Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haskell implementation not rejecting keyword labels #1750

Closed
Gabriella439 opened this issue Apr 14, 2020 · 0 comments · Fixed by #1801
Closed

Haskell implementation not rejecting keyword labels #1750

Gabriella439 opened this issue Apr 14, 2020 · 0 comments · Fixed by #1801
Labels
bug parser standard compliance

Comments

@Gabriella439
Copy link
Collaborator

The standard requires record labels to not be keywords:

https://github.com/dhall-lang/dhall-lang/blob/master/standard/dhall.abnf#L226

... but the Haskell implementation does not correctly reject them. For example, this expression:

$ dhall <<< '{ if : Text }'
{ if : Text }

... should have been rejected. See also: travisbrown/dhallj#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug parser standard compliance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(parser): record fields should not include language keywords dhall-lang/dhall-haskell
2 participants
@Gabriella439 @sjakobi