Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liccheck 0.3.11 installation is broken #29

Closed
westphahl opened this issue Jun 13, 2019 · 5 comments · Fixed by #30
Closed

liccheck 0.3.11 installation is broken #29

westphahl opened this issue Jun 13, 2019 · 5 comments · Fixed by #30
Labels

Comments

@westphahl
Copy link

It seems the installation of liccheck 0.3.11 is broken:

$ pip install liccheck                                                                                                                                                                       ~/tmp/liccheck {#}
Collecting liccheck
  Downloading https://files.pythonhosted.org/packages/91/a7/83118d3ba708ebdf29c6bdd7a593d7297311492fe7ca63854ae0c8cbff20/liccheck-0.3.11.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-kdjtfgh6/liccheck/setup.py", line 20, in <module>
        with open(path.join(here, 'requirements.txt'), encoding='utf-8') as f:
      File "/usr/lib/python3.7/codecs.py", line 898, in open
        file = builtins.open(filename, mode, buffering)
    FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-install-kdjtfgh6/liccheck/requirements.txt'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-kdjtfgh6/liccheck/
@ochedru
Copy link
Collaborator

ochedru commented Jun 13, 2019

Oops. This is a regression introduced by #28. @shakhat, can you please have a look? Meanwhile, I am reverting and release 0.3.12.

@ochedru
Copy link
Collaborator

ochedru commented Jun 13, 2019

@shakhat I revert parsing of (missing) requirements.txt and hardcoded install_requires. This should do the trick.

@ochedru
Copy link
Collaborator

ochedru commented Jun 13, 2019

0.3.12 is ok. Thank you for your bug report @westphahl!

@ochedru ochedru closed this as completed Jun 13, 2019
@ochedru ochedru added the bug label Jun 13, 2019
@shakhat
Copy link
Contributor

shakhat commented Jun 14, 2019

Oops. This is a regression introduced by #28. @shakhat, can you please have a look? Meanwhile, I am reverting and release 0.3.12.

I should have added requirements.txt into manifest file... My fault.

So the correct solution is to add MANIFEST.in with the line "include requirements.txt". This instructs dist to put requirements.txt into the build.

@ochedru Would you like me to propose the correct patch?

@ochedru
Copy link
Collaborator

ochedru commented Jun 14, 2019

@ochedru Would you like me to propose the correct patch?

Sure, go ahead! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants