Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpsProtocol dev certs no longer working as of 9.1.3 #1528

Closed
aldenquimby opened this issue Aug 4, 2022 · 2 comments · Fixed by #1529
Closed

httpsProtocol dev certs no longer working as of 9.1.3 #1528

aldenquimby opened this issue Aug 4, 2022 · 2 comments · Fixed by #1529
Labels

Comments

@aldenquimby
Copy link
Contributor

aldenquimby commented Aug 4, 2022

Bug Report

Current Behavior

  • After upgrading from v8 to the latest v9.1.5, my local build failed with the following error:
TypeError [ERR_INVALID_ARG_TYPE]: The "options.cert" property must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Promise
  • Downgrading to v9.1.2 fixes the issue

Sample Code

  • file: serverless.yml
  serverless-offline:
    httpsProtocol: 'dev-certs'

Expected behavior/code

  • dev server boots without errors

Environment

  • serverless version: v3.21.0
  • serverless-offline version: v9.1.5
  • node.js version: v14.18.18
  • OS: macOS

Possible Solution
Consider reverting 7019d28

@dnalborczyk
Copy link
Collaborator

thank you for filing the issue @aldenquimby

a fix is on the way, just need to add some tests so it won't break again in the future.

@dnalborczyk
Copy link
Collaborator

@aldenquimby could you give v9.1.6 a try? I couldn't get the tests working quickly so I try to add them at a later time. I need to read up more about the usage of the certs and how to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants