fix: Allow string values in provider.apiGateway.apiKeys #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the problem where `getApiKeysValues` would only allow `FIRST_API_KEY` in the following config, and not `SECOND_API_KEY` because it's not an object.
```yaml
provider:
name: aws
apiGateway:
apiKeys:
- name: FIRST_API_KEY_NAME
value: FIRST_API_KEY
- SECOND_API_KEY
```
Strings are supported, according to the serverless (docs)[https://www.serverless.com/framework/docs/providers/aws/guide/serverless.yml#api-gateway-v1-rest-api].
Allows using standard serverless syntax
Tested with unit tests
Fixes dherault#1661
|
I guess there's a use case for API_KEYs that can be empty strings? |
dnalborczyk
changed the title
|
+1 support string x-api-keys |
|
thank you @andersem ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the problem where
getApiKeysValueswould only allowFIRST_API_KEYin the following config, and notSECOND_API_KEYbecause it's not an object.Strings are supported, according to the serverless (docs)[https://www.serverless.com/framework/docs/providers/aws/guide/serverless.yml#api-gateway-v1-rest-api].
Motivation and Context
Fixes #1661
How Has This Been Tested?
Tested with unit tests with both types of input