Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function specific runtimes #750

Closed
ed-sparkes opened this issue Jul 18, 2019 · 1 comment
Closed

Function specific runtimes #750

ed-sparkes opened this issue Jul 18, 2019 · 1 comment

Comments

@ed-sparkes
Copy link

ed-sparkes commented Jul 18, 2019

Hi,

My project has a mix of runtimes, python and node and as such i dont specify the runtime at the provider level, if i do other plugins seem to get confused.

However if i dont specify a runtime at the provider level, serverless offline throws an error

 if (!serviceRuntime) {
      throw new Error('Missing required property "runtime" for provider.');
    }

It appears serverless offline supports multiple runtimes, but still requires a provider level runtime to be set. Perhaps the above check could check that if provider level not provided then check that all function specs have a provided runtime?

@dnalborczyk
Copy link
Collaborator

hey @ed-sparkes,

thank you for the report! you're right, that's a short-coming which should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants